Update SlipGajiServiceImpl.java

Perbaikan validasi null existing slip gaji
This commit is contained in:
Salman Manoe 2023-04-26 08:08:02 +07:00
parent 29247ed49d
commit a4e4fdaca8

View File

@ -144,7 +144,7 @@ public class SlipGajiServiceImpl implements SlipGajiService {
Date start = DateUtil.startMonth(month);
Date end = DateUtil.endMonth(month);
Optional<SlipGaji> existedSlipGaji = slipGajiDao.findByPegawaiAndBulan(dto.getIdPegawai(), start, end);
if (existedSlipGaji.isPresent()) {
if (CommonUtil.isNotNullOrEmpty(existedSlipGaji) && existedSlipGaji.isPresent()) {
slipGaji.id(existedSlipGaji.get().getId());
} else if (CommonUtil.isNotNullOrEmpty(dto.getId())) {
slipGaji.id(dto.getId());
@ -153,7 +153,7 @@ public class SlipGajiServiceImpl implements SlipGajiService {
slipGaji.bulan(month);
SlipGaji savedSlip = slipGajiDao.save(slipGaji.build());
if (CommonUtil.isNotNullOrEmpty(savedSlip)) {
if (!existedSlipGaji.isPresent() && CommonUtil.isNullOrEmpty(dto.getId())) {
if (CommonUtil.isNullOrEmpty(existedSlipGaji) && CommonUtil.isNullOrEmpty(dto.getId())) {
List<MapPegawaiJabatanToUnitKerja> listMapping = mappingJabatanDao.findByPegawaiId(dto.getIdPegawai());
List<SlipGajiDetail> listDetail = new ArrayList<>();
listMapping.forEach(j -> {