Merge branch 'dev/base' into dev/technical-debt/clean-code

This commit is contained in:
Salman Manoe 2025-02-03 13:39:03 +07:00
commit c3ee97b3d2
3 changed files with 7 additions and 6 deletions

View File

@ -22,7 +22,8 @@ public interface PegawaiDaoCustom extends CoreDao<Pegawai> {
List<Integer> listStatusPegawai, List<Integer> listKedudukan); List<Integer> listStatusPegawai, List<Integer> listKedudukan);
List<Map<String, Object>> findPegawaiCustom(String nama, Integer idUnitKerja, Integer idKedudukan, List<Map<String, Object>> findPegawaiCustom(String nama, Integer idUnitKerja, Integer idKedudukan,
List<Integer> listStatusPegawaiId, String periode, List<Integer> listKedudukanException); List<Integer> listStatusPegawaiId, String periode, List<Integer> listKedudukanException,
List<Integer> listStatusPegawaiException);
List<Map<String, Object>> findPegawaiCustomByKategori(String nama, Integer idUnitKerja, Integer idKedudukan, List<Map<String, Object>> findPegawaiCustomByKategori(String nama, Integer idUnitKerja, Integer idKedudukan,
String periode, List<Integer> listKedudukanException, List<Integer> listIdKategori); String periode, List<Integer> listKedudukanException, List<Integer> listIdKategori);

View File

@ -273,7 +273,8 @@ public class PegawaiDaoCustomImpl extends CoreDaoImpl<Pegawai> implements Pegawa
@Override @Override
public List<Map<String, Object>> findPegawaiCustom(String nama, Integer idUnitKerja, Integer idKedudukan, public List<Map<String, Object>> findPegawaiCustom(String nama, Integer idUnitKerja, Integer idKedudukan,
List<Integer> listStatusPegawaiId, String periode, List<Integer> listKedudukanException) { List<Integer> listStatusPegawaiId, String periode, List<Integer> listKedudukanException,
List<Integer> listStatusPegawaiException) {
StringBuffer buffer = new StringBuffer(); StringBuffer buffer = new StringBuffer();
List<Map<String, Object>> list = new ArrayList<>(); List<Map<String, Object>> list = new ArrayList<>();
@ -397,7 +398,7 @@ public class PegawaiDaoCustomImpl extends CoreDaoImpl<Pegawai> implements Pegawa
query.setParameter("listAdmin", listAdmin); query.setParameter("listAdmin", listAdmin);
if (CommonUtil.isNullOrEmpty(listStatusPegawaiId)) { if (CommonUtil.isNullOrEmpty(listStatusPegawaiId)) {
query.setParameter("nonSdmKategory", Arrays.asList(Master.KategoryPegawai.NONSDM)); query.setParameter("nonSdmKategory", listStatusPegawaiException);
} }
if (CommonUtil.isNotNullOrEmpty(idUnitKerja) && CommonUtil.isNotNullOrEmpty(listPegawaiByUnitKerja) if (CommonUtil.isNotNullOrEmpty(idUnitKerja) && CommonUtil.isNotNullOrEmpty(listPegawaiByUnitKerja)

View File

@ -727,10 +727,9 @@ public class PegawaiServiceImpl extends BaseVoServiceImpl implements PegawaiServ
List<Integer> listStatusPegawaiId, String periode) { List<Integer> listStatusPegawaiId, String periode) {
Map<String, Object> result = new HashMap<>(); Map<String, Object> result = new HashMap<>();
List<Map<String, Object>> resultModelWithUsername = new ArrayList<>(); List<Map<String, Object>> resultModelWithUsername = new ArrayList<>();
if (CommonUtil.isNullOrEmpty(listStatusPegawaiId))
listStatusPegawaiId = splitDataSettingDatafixed("listIdKategoryPegawaiNonSdm");
List<Map<String, Object>> resultModel = pegawaiDaoCustom.findPegawaiCustom(nama, idUnitKerja, idKedudukan, List<Map<String, Object>> resultModel = pegawaiDaoCustom.findPegawaiCustom(nama, idUnitKerja, idKedudukan,
listStatusPegawaiId, periode, splitDataSettingDatafixed("listDataKedudukanException")); listStatusPegawaiId, periode, splitDataSettingDatafixed("listDataKedudukanException"),
splitDataSettingDatafixed("listIdKategoryPegawaiNonSdm"));
for (Map<String, Object> map : resultModel) { for (Map<String, Object> map : resultModel) {
Map<String, Object> usernames = new HashMap<>(); Map<String, Object> usernames = new HashMap<>();