From 9e1138801ca326c219bc8a8783ce3884a6197122 Mon Sep 17 00:00:00 2001 From: Salman Manoe Date: Tue, 28 Nov 2023 07:46:10 +0700 Subject: [PATCH 1/3] Update service slip gaji Clean code --- .../medifirst2000/service/SlipGajiService.java | 9 +++------ .../service/impl/SlipGajiServiceImpl.java | 12 ------------ 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/SlipGajiService.java b/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/SlipGajiService.java index dd0a128e..76df0ea0 100644 --- a/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/SlipGajiService.java +++ b/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/SlipGajiService.java @@ -1,12 +1,11 @@ package com.jasamedika.medifirst2000.service; -import java.io.IOException; -import java.util.List; -import java.util.Map; - import com.jasamedika.medifirst2000.dto.KomponenGajiDto; import com.jasamedika.medifirst2000.dto.SlipGajiDto; +import java.io.IOException; +import java.util.List; + /** * @author salmanoe * @since Jan 20, 2023 @@ -24,7 +23,5 @@ public interface SlipGajiService { String writeExcel(Long bulan) throws IOException; - Map previewPdf(Integer pegawaiId, Long bulan); - List listKomponen(); } diff --git a/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/impl/SlipGajiServiceImpl.java b/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/impl/SlipGajiServiceImpl.java index d3f7e43b..894fde13 100644 --- a/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/impl/SlipGajiServiceImpl.java +++ b/jasamedika-business/src/main/java/com/jasamedika/medifirst2000/service/impl/SlipGajiServiceImpl.java @@ -542,18 +542,6 @@ public class SlipGajiServiceImpl implements SlipGajiService { return absoluteFilePath; } - @Override - public Map previewPdf(Integer pegawaiId, Long bulan) { - SlipGajiDto dto = this.get(pegawaiId, bulan); - Map result = new HashMap<>(); - result.put("namaPegawai", dto.getNamaPegawai()); - result.put("nip", dto.getNip()); - result.put("jabatan", dto.getJabatan()); - result.put("unitKerja", dto.getUnitKerja()); - result.put("subUnitKerja", dto.getSubUnitKerja()); - return result; - } - @Override public List listKomponen() { List result = new ArrayList<>(); From 6b999994d40c8b69a01371aa173d69ee01bfccb6 Mon Sep 17 00:00:00 2001 From: Salman Manoe Date: Tue, 28 Nov 2023 07:46:29 +0700 Subject: [PATCH 2/3] Update slipGaji.jrxml Perbaikan redaksional footer slip gaji --- .../src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml b/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml index 7ad5ab64..46fe97ca 100644 --- a/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml +++ b/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml @@ -1724,7 +1724,7 @@ - + From a269b4d25aadf82731004218cccf644898a8d102 Mon Sep 17 00:00:00 2001 From: Salman Manoe Date: Tue, 28 Nov 2023 07:46:29 +0700 Subject: [PATCH 3/3] Update slipGaji.jrxml Perbaikan redaksional footer slip gaji --- .../WEB-INF/templates/jrxml/slipGaji.jrxml | 39 +++++++++++++------ 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml b/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml index 7ad5ab64..bcd50a56 100644 --- a/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml +++ b/jasamedika-reporting/src/main/webapp/WEB-INF/templates/jrxml/slipGaji.jrxml @@ -65,7 +65,7 @@ - + @@ -1716,16 +1716,6 @@ - - - - - - - - - - @@ -1804,6 +1794,33 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + +